Use supertap to generate TAP output #1610
Merged
+67
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimdemedes
force-pushed
the
supertap
branch
from
e65f597 to
f3222bd
Compare
vadimdemedes
force-pushed
the
supertap
branch
from
f3222bd to
c6ac5ab
Compare
Member
novemberborn
left a comment
novemberborn
left a comment
There was a problem hiding this comment.
Uses vadimdemedes/supertap to generate TAP output, without changing a single line of tests and a lot of the code was extracted from AVA itself
Yay!
so it's pretty much backwards compatible.
Heh, "pretty much" implies there might be some behavioral changes?
| todo: test.todo, | ||
| skip: test.skip, | ||
| comment: test.logs, | ||
| error: test.error ? dumpError(test.error, true) : null |
Member
There was a problem hiding this comment.
dumpError doesn't return an Error instance, which supertaps API says is expected. Perhaps the API documentation should be loosened, or clearer on what properties are expected on non-Error objects?
Contributor
Author
There was a problem hiding this comment.
Agree, will clarify that.
Contributor
Author
I don't think so, since I haven't modified AVA's tests and they pass 😉 |
Collinslenjo
added a commit
to Collinslenjo/ava
that referenced
this pull request
Dec 19, 2017
Use supertap to generate TAP output (avajs#1610)
This was referenced Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/vadimdemedes/supertap to generate TAP output, without changing a single line of tests and a lot of the code was extracted from AVA itself, so it's pretty much backwards compatible.